Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment_linter when comment further on in brace #1702

Merged

Conversation

ashbaldry
Copy link
Contributor

Resolves #1701

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #1702 (baccc59) into main (71610e3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head baccc59 differs from pull request most recent head 1db1e79. Consider uploading reports for the commit 1db1e79 to get more accurate results

@@           Coverage Diff           @@
##             main    #1702   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         104      104           
  Lines        4494     4494           
=======================================
  Hits         4439     4439           
  Misses         55       55           
Impacted Files Coverage Δ
R/assignment_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelChirico
Copy link
Collaborator

Thanks, LGTM! Please add a NEWS entry & then we can merge

@MichaelChirico
Copy link
Collaborator

Thanks!

@MichaelChirico MichaelChirico merged commit fb092eb into r-lib:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assignment_linter(allow_trailing = FALSE) fails when comment in brace
3 participants