Further reading for no tabs linter #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +21,10 @@ | |||
| #' | |||
| #' @evalRd rd_tags("no_tab_linter") | |||
| #' @seealso [linters] for a complete list of linters available in lintr. | |||
| #' | |||
| #' @references | |||
| #' - https://www.jwz.org/doc/tabs-vs-spaces.html | |||
There was a problem hiding this comment.
my only concern is that blogs like this tend to wind up as a maintenance headache in the long term as redirects evolve / pages die.
but fine to leave it in for now
MichaelChirico
approved these changes
Oct 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #1690 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 104 104
Lines 4497 4497
=======================================
Hits 4439 4439
Misses 58 58 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
IndrajeetPatil
added a commit
that referenced
this pull request
Nov 18, 2022
Inspired by this comment (#1690 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1672