Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to documentation: Part-9 (cleanup) #1688

Merged
merged 5 commits into from
Oct 12, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

Part of #1492

@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico Do you mind adding examples for nonportable_path_linter()?

I couldn't manage to do it, and that's the only one that remains. Feel free to push in this PR itself, if you can work on it.

@IndrajeetPatil IndrajeetPatil linked an issue Oct 12, 2022 that may be closed by this pull request
78 tasks
@MichaelChirico
Copy link
Collaborator

Do you mind adding examples for nonportable_path_linter()?

Was this a matter of not understanding the linter?

I also don't understand the path linters TBH, but I can look into it if you'd like :)

@IndrajeetPatil
Copy link
Collaborator Author

Was this a matter of not understanding the linter?
I also don't understand the path linters TBH, but I can look into it if you'd like :)

Partly poor understanding, and partly frustration with creating working examples. Anything and everything I tried, it either linted or produced error because escapes and what not, so decided to give up.

@MichaelChirico
Copy link
Collaborator

ok, let's just leave it as a follow-up. those linters need some love / refactoring anyway & are not on by default, I'm fine to proceed.

@MichaelChirico MichaelChirico merged commit 5ea4ca8 into main Oct 12, 2022
@MichaelChirico MichaelChirico deleted the 1492_closing_pr branch October 12, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding examples to documentation of each linter
2 participants