-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to documentation: Part-8 (t-z) #1686
Conversation
#' | ||
#' # okay | ||
#' lint( | ||
#' text = "x <- NULL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also present the alternative of x <- integer(10) for cases where c() was meant to seed a vector of known size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it warrants a comment on the example to say why it's there, otherwise there's a bit of a "what's this example got to do w anything?" reaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Added a comment.
Codecov Report
@@ Coverage Diff @@
## main #1686 +/- ##
==========================================
- Coverage 98.71% 98.71% -0.01%
==========================================
Files 104 104
Lines 4499 4497 -2
==========================================
- Hits 4441 4439 -2
Misses 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done!
Part of #1492
Doesn't close the issue yet. A couple of items and some cleanup remaining.