unnecessary_placeholder_linter() covers a few other ops

R/unnecessary_placeholder_linter.R

@@ -4,6 +4,8 @@
 #'   passed as the first positional argument; using it can cause confusion
 #'   and impacts readability.
 #'
+#' This is true for forward (`%>%`), assignment (`%<>%`), and tee (`%T>%`) operators.
+#'
 #' @examples
 #' # will produce lints
 #' lint(
@@ -33,7 +35,7 @@
 unnecessary_placeholder_linter <- function() {
   # TODO(michaelchirico): handle R4.2.0 native placeholder _ as well
   xpath <- "
-  //SPECIAL[text() = '%>%']
+  //SPECIAL[text() = '%>%' or text() = '%T>%' or text() = '%<>%']
     /following-sibling::expr[
       expr/SYMBOL_FUNCTION_CALL
       and not(expr[

tests/testthat/test-unnecessary_placeholder_linter.R

@@ -1,25 +1,38 @@
-test_that("unnecessary_placeholder_linter skips allowed usages", {
-  # . used in position other than first --> ok
-  expect_lint("x %>% foo(y, .)", NULL, unnecessary_placeholder_linter())
-  # ditto for nested usage
-  expect_lint("x %>% foo(y, bar(.))", NULL, unnecessary_placeholder_linter())
-  # . used twice --> ok
-  expect_lint("x %>% foo(., .)", NULL, unnecessary_placeholder_linter())
-  # . used as a keyword argument --> ok
-  expect_lint("x %>% foo(arg = .)", NULL, unnecessary_placeholder_linter())
-})
+skip_if_not_installed("patrick")
+patrick::with_parameters_test_that(
+  "unnecessary_placeholder_linter skips allowed usages",
+  {
+    linter <- unnecessary_placeholder_linter()
 
-test_that("unnecessary_placeholder_linter blocks simple disallowed usages", {
-  expect_lint(
-    "x %>% sum(.)",
-    rex::rex("Don't use the placeholder (`.`) when it's not needed"),
-    unnecessary_placeholder_linter()
-  )
+    # . used in position other than first --> ok
+    expect_lint(sprintf("x %s foo(y, .)", pipe), NULL, linter)
+    # ditto for nested usage
+    expect_lint(sprintf("x %s foo(y, bar(.))", pipe), NULL, linter)
+    # . used twice --> ok
+    expect_lint(sprintf("x %s foo(., .)", pipe), NULL, linter)
+    # . used as a keyword argument --> ok
+    expect_lint(sprintf("x %s foo(arg = .)", pipe), NULL, linter)
+  },
+  .test_name = c("forward", "assignment", "tee"),
+  pipe = c("%>%", "%<>%", "%T>%")
+)
 
-  # can come anywhere in the pipeline
-  expect_lint(
-    "x %>% y(.) %>% sum()",
-    rex::rex("Don't use the placeholder (`.`) when it's not needed"),
-    unnecessary_placeholder_linter()
-  )
-})
+patrick::with_parameters_test_that(
+  "unnecessary_placeholder_linter blocks simple disallowed usages",
+  {
+    linter <- unnecessary_placeholder_linter()
+    expect_lint(
+      sprintf("x %s sum(.)", pipe),
+      rex::rex("Don't use the placeholder (`.`) when it's not needed"),
+      unnecessary_placeholder_linter()
+    )
+
+    expect_lint(
+      sprintf("x %s y(.) %s sum()", pipe, pipe),
+      rex::rex("Don't use the placeholder (`.`) when it's not needed"),
+      unnecessary_placeholder_linter()
+    )
+  },
+  .test_name = c("forward", "assignment", "tee"),
+  pipe = c("%>%", "%<>%", "%T>%")
+)