Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split S3 and S4 linters (and tests) into their own files #1680

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

This always made me do double-take if I was working in the right file.

This always made me do double-take if I was working in the right file.
MichaelChirico
MichaelChirico previously approved these changes Oct 11, 2022
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see a need for this but sure :)

@IndrajeetPatil IndrajeetPatil added the internals Issues related to inner workings of lintr, i.e., not user-visible label Oct 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1680 (36f9c3e) into main (849c40e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1680   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         103      104    +1     
  Lines        4498     4498           
=======================================
  Hits         4440     4440           
  Misses         58       58           
Impacted Files Coverage Δ
R/expect_s3_class_linter.R 100.00% <ø> (ø)
R/expect_s4_class_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelChirico MichaelChirico merged commit 719784c into main Oct 11, 2022
@MichaelChirico MichaelChirico deleted the split_s3_s4 branch October 11, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants