Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sprintf_linter works for gettextf #1679

Merged
merged 7 commits into from
Oct 11, 2022
Merged

sprintf_linter works for gettextf #1679

merged 7 commits into from
Oct 11, 2022

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1677

IndrajeetPatil
IndrajeetPatil previously approved these changes Oct 11, 2022
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look rad now. Thanks!

@IndrajeetPatil
Copy link
Collaborator

Merge conflict.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #1679 (4ffe88a) into main (719784c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4ffe88a differs from pull request most recent head 4c6c023. Consider uploading reports for the commit 4c6c023 to get more accurate results

@@           Coverage Diff           @@
##             main    #1679   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         104      104           
  Lines        4498     4498           
=======================================
  Hits         4440     4440           
  Misses         58       58           
Impacted Files Coverage Δ
R/sprintf_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit e93aed7 into main Oct 11, 2022
@IndrajeetPatil IndrajeetPatil deleted the sprintf-gettext branch October 11, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sprintf_linter can apply to gettextf as well
3 participants