Add examples to documentation: Part-6 (o-p) #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/paste_linter.R
Outdated
| #' ) | ||
| #' | ||
| #' lint( | ||
| #' text = "paste0(rep('*', 10L), collapse='')", |
There was a problem hiding this comment.
let's use collapse = '' to be closer to the style guide
(I guess that means maybe we should switch to using " in the code too? WDYT?)
There was a problem hiding this comment.
Ah, yes, that's a good point.
I have changed this particular example here, but I will make a separate PR to change all the existing examples to make sure that they all follow the style guide.
Codecov Report
@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 102 102
Lines 4474 4474
=======================================
Hits 4416 4416
Misses 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MichaelChirico
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1492