small simplification for glue, add coverage test #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
commented
Oct 10, 2022
| @@ -165,8 +165,7 @@ extract_glued_symbols <- function(expr) { | |||
| parse(text = xml2::xml_text(cl)), | |||
| error = function(...) NULL, | |||
| warning = function(...) NULL | |||
| )[[1L]] | |||
| if (is.null(parsed_cl)) next | |||
There was a problem hiding this comment.
I can't think of how we could end up with a parsing error here... if there's a flaw in our thinking that might lead to that happening, we should let it cause an error & users can report it so we can tighten the logic elsewhere.
| @@ -160,13 +160,16 @@ extract_glued_symbols <- function(expr) { | |||
| } | |||
| glued_symbols <- new.env(parent = emptyenv()) | |||
|
|
|||
| unexpected_error <- function(cond) { | |||
| stop("Unexpected failure to parse glue call, please report: ", conditionMessage(cond)) | |||
There was a problem hiding this comment.
Can we add a test to make sure that we get this expected error message?
There was a problem hiding this comment.
no -- I don't know how to trigger the error. it should be nocov but covr doesn't separate out tryCatch branches
IndrajeetPatil
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
length(parsed_text) == 0also covers the case likeglue("{}")where an empty expression is parsed (parsed_textisexpression()). I don't see hownrow(parse_data) == 0is possible after that (even a comment generates parse data).