Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New empty_assignment_linter #1637

Merged
merged 7 commits into from
Oct 8, 2022
Merged

New empty_assignment_linter #1637

merged 7 commits into from
Oct 8, 2022

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #1637 (1cbdf8a) into main (bda3739) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   98.26%   98.27%           
=======================================
  Files          99      100    +1     
  Lines        4376     4394   +18     
=======================================
+ Hits         4300     4318   +18     
  Misses         76       76           
Impacted Files Coverage Δ
R/empty_assignment_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil
Copy link
Collaborator

These should produce lints, right?

library(lintr)

{} -> x
x
#> NULL

lint(text = "{} -> x", linters = empty_assignment_linter())
lint(text = "{} ->> x", linters = empty_assignment_linter())

Created on 2022-10-08 with reprex v2.0.2

P.S. Funny branch name 😆

@MichaelChirico
Copy link
Collaborator Author

These should produce lints, right?

yep; had left it as a TODO but it's a trivial addition; done

P.S. Funny branch name

😅

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff. Thanks!

@IndrajeetPatil IndrajeetPatil self-requested a review October 8, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants