Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle backtickd names in glue extraction #1630

Merged
merged 9 commits into from
Oct 13, 2022
Merged

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1619

R/zzz.R Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Merging #1630 (4d5002c) into main (ab8b77d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files         102      102              
  Lines        4474     4470       -4     
==========================================
- Hits         4416     4412       -4     
  Misses         58       58              
Impacted Files Coverage Δ
R/object_usage_linter.R 94.76% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelChirico
Copy link
Collaborator Author

Bump: @AshesITR. Ping if you don't have time & I can re-assign to Indrajeet, thanks!

@MichaelChirico MichaelChirico requested review from IndrajeetPatil and removed request for AshesITR October 12, 2022 05:39
@MichaelChirico
Copy link
Collaborator Author

@IndrajeetPatil could you PTAL here?

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cool unit test. 😎

@IndrajeetPatil IndrajeetPatil merged commit d9517a9 into main Oct 13, 2022
@IndrajeetPatil IndrajeetPatil deleted the glue-backticks branch October 13, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glue symbol extraction should treat x and ` x ` the same
3 participants