Add more missing tests #1624
Merged
Add more missing tests #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndrajeetPatil
commented
Oct 6, 2022
| @@ -84,7 +84,7 @@ wercker_build_info <- function() { | |||
| # nocov start | |||
| github_comment <- function(text, info = NULL, token = settings$comment_token) { | |||
| if (!requireNamespace("httr", quietly = TRUE)) { | |||
| stop("Package 'httr' is required to post comments with github_comment().") # nocov | |||
There was a problem hiding this comment.
Not necessary since this entire function is being ignored for code coverage.
Codecov Report
@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
+ Coverage 96.00% 96.22% +0.22%
==========================================
Files 98 98
Lines 4350 4350
==========================================
+ Hits 4176 4186 +10
+ Misses 174 164 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MichaelChirico
approved these changes
Oct 6, 2022
IndrajeetPatil
commented
Oct 15, 2022
Comment on lines
+8
to
+9
| lintr:::reset_lang(old_lang) | ||
| expect_identical(Sys.getenv("LANGUAGE"), old_lang) |
There was a problem hiding this comment.
@MichaelChirico Is it not strange that even with these tests merged into the main, codecov still says that reset_lang() is not covered by any tests?
There was a problem hiding this comment.
try a test commit where you add a stop() inside reset_lang(), to ensure it's actually being run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.