Improve resilience of object_usage_linter() to glue syntax issues #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshesITR
reviewed
Oct 3, 2022
|
Hey @IndrajeetPatil another reason to please resist being trigger-happy with the I'd rather handle merges to main locally if needed, then push directly to remote. Basically as long as there's no merge conflict, I don't see any need to do an Update until just before the PR is merged. |
|
Oops, sorry about that. I thought this was ready for a merge since you made a commit to address Alexander's comment. But I was mistaken about that. I will refrain from updating anyone else's PR in the future to avoid this. |
AshesITR
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1459
This invalidated the earlier test added in #1583, but we can test it more directly / without a fake package, as done here.