Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove {covr} unneeded from Suggests #1560

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Remove {covr} unneeded from Suggests #1560

merged 4 commits into from
Sep 26, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review September 26, 2022 16:56
@IndrajeetPatil IndrajeetPatil changed the title Check if covr is needed in Suggests Remove {covr} unneeded from Suggests Sep 26, 2022
@MichaelChirico
Copy link
Collaborator

Any reason for removing covr in particular?

To me it's part of Suggests since it should technically be part of our CI suite, though that job appears to be broken for quite some time.

@IndrajeetPatil
Copy link
Collaborator Author

it should technically be part of our CI suite

It is part of our CI suite:

extra-packages: any::covr

It just doesn't need to be a soft dependency, since we are not using any functions from it, IINM.

@MichaelChirico
Copy link
Collaborator

I think you're technically right, but I still think it's a good idea to keep it in Suggests. This will help the covr maintainers discover its downstreams / report any issues that might affect us, for example.

@IndrajeetPatil
Copy link
Collaborator Author

discover its downstreams / report any issues that might affect us

But this is what I don't understand. How can it affect us if we use no functionality from it?

We rely on it only via testthat::skip_on_covr(), so it will affect {testthat}, but not us. Am I mistaken about this?

@MichaelChirico
Copy link
Collaborator

Filed r-lib/covr#515 to help clarify covr maintainers' preferences. Let's merge this for now.

@IndrajeetPatil IndrajeetPatil merged commit 9e1f8ba into main Sep 26, 2022
@IndrajeetPatil IndrajeetPatil deleted the is_covr_needed branch September 26, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants