Sync up with lint workflow in r-lib/actions
#1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndrajeetPatil
commented
Sep 25, 2022
|
|
||
| - name: Install package | ||
| run: R CMD INSTALL . | ||
| r-lib/lintr |
There was a problem hiding this comment.
This is the only deviation from what's in the standard example workflow for linting.
I think we should always be linting with the latest GitHub version of {lintr}.
| branches: | ||
| - main | ||
| - master | ||
| branches: [main, master] |
There was a problem hiding this comment.
any reason to keep master here? just to keep perfectly synced with the upstream source?
There was a problem hiding this comment.
Yes, no other reason. Can also remove it. Fine either way.
There was a problem hiding this comment.
SGTM, thanks for clarifying
MichaelChirico
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.