Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve dataset symbol detection #1555

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Conversation

MichaelChirico
Copy link
Collaborator

Follow-up to #1549, the Items column has a funny format for some objects, per ?data:

Where the datasets have a different name from the
argument that should be used to retrieve them the index will have
an entry like ‘beaver1 (beavers)’ which tells us that dataset
‘beaver1’ can be retrieved by the call ‘data(beaver)’.

From experimenting, it looks like beaver1 is the one we want to allow.

MichaelChirico and others added 2 commits September 24, 2022 12:46
Follow-up to #1549, the `Items` column has a funny format for some objects, per `?data`:

```
Where the datasets have a different name from the
argument that should be used to retrieve them the index will have
an entry like ‘beaver1 (beavers)’ which tells us that dataset
‘beaver1’ can be retrieved by the call ‘data(beaver)’.
```
@IndrajeetPatil IndrajeetPatil self-requested a review September 24, 2022 20:12
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks.

@IndrajeetPatil IndrajeetPatil merged commit c5a2ae0 into main Sep 24, 2022
@IndrajeetPatil IndrajeetPatil deleted the MichaelChirico-patch-1 branch September 24, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants