-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anticipate more knitr engines in code blocks #1552
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
4d7b0a8
Anticipate raw HTML from extended knitr engines
IndrajeetPatil 96497bc
Also include bookdown engines
IndrajeetPatil ca1580d
don't piggyback; move tests to their own file
IndrajeetPatil 1665e3d
also add test for bookdown engines; ignore file
IndrajeetPatil cc55556
also update .lintr_new
IndrajeetPatil 61e6864
Update test-knitr_formats.R
IndrajeetPatil c617762
Update NEWS.md
IndrajeetPatil 1e9f4b7
Merge branch 'main' into 796_tufte
IndrajeetPatil f27fb13
Merge branch 'main' into 796_tufte
IndrajeetPatil 9a5a380
Merge branch 'main' into 796_tufte
IndrajeetPatil 2fd0e54
Merge branch 'main' into 796_tufte
IndrajeetPatil d6de1eb
don't use bookdown vector
IndrajeetPatil 17455b8
Merge branch 'main' into 796_tufte
IndrajeetPatil 16de9df
Merge branch 'main' into 796_tufte
IndrajeetPatil fb79a0b
Merge branch 'main' into 796_tufte
IndrajeetPatil 539335a
Merge branch 'main' into 796_tufte
IndrajeetPatil 631d98c
address review comment
IndrajeetPatil cba39a1
Update test-knitr_extended_formats.R
IndrajeetPatil d374480
Merge branch 'main' into 796_tufte
IndrajeetPatil f983f2f
Merge branch 'main' into 796_tufte
IndrajeetPatil e896bb3
update comment
IndrajeetPatil ca66e97
fix tests
IndrajeetPatil 1dedc78
Merge branch 'main' into 796_tufte
IndrajeetPatil 49c35b6
Merge branch 'main' into 796_tufte
IndrajeetPatil ac9a698
Merge branch 'main' into 796_tufte
IndrajeetPatil 26bcf1d
Use `loadNamespace()` instead
IndrajeetPatil 94c50f3
Merge branch 'main' into 796_tufte
IndrajeetPatil bf42e61
Merge branch 'main' into 796_tufte
IndrajeetPatil c69c387
Merge branch 'main' into 796_tufte
IndrajeetPatil e16f589
Update for tufte update
IndrajeetPatil 44d649b
Update NEWS.md
IndrajeetPatil a0f6741
Merge branch 'main' into 796_tufte
IndrajeetPatil c47975f
Merge branch 'main' into 796_tufte
MichaelChirico 89bafe5
extend/clarify comment
MichaelChirico aaa1604
qualify rex namespace, use test_path()
MichaelChirico 933813a
use test_path()
MichaelChirico d4f056b
much-extended NEWS item
MichaelChirico 70d852c
grammar fix
MichaelChirico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IndrajeetPatil PTAL. I moved it from "bug fixes" because there's no longer any code change by lintr. I still don't feel like I have a 100% grasp of the situation, so feel free to refine the item further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Michael. This looks good to me.
I think we can revise this further as our understanding of the issue evolves while working on #1617.