Add sort_linter() #1528
Merged
Add sort_linter() #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the Contributor list is only recording folks with a "substantial" contribution history |
Codecov Report
@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
+ Coverage 98.88% 98.89% +0.01%
==========================================
Files 109 110 +1
Lines 4648 4692 +44
==========================================
+ Hits 4596 4640 +44
Misses 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Oops, sorry for the spam, I was trying to request another round of review from both reviewers but looks like I can only select one at a time, hence the confusion 😞 |
AshesITR
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1512
I'm happy to receive feedback on this PR and revisit as much as needed. I'm not super familiar with XPath so I did the best I could.
Also, should I add myself as a contributor?