Replace igraph calls with our own R code, get rid of igraph #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #151. |
|
Looks great, could you add a note to NEWS.md then I will happily merge. |
|
I am not sure what you want in the NEWS, nothing has changed in the API, right? Just that it is not depending on igraph now? |
|
Yeah just mentioning the dependency is removed is fine. I don't typically restrict NEWS mentions to just API changes, but maybe that is a good practice... |
|
OK, added the bullet point to the NEWS. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is also faster, at least the complicated QC.R case. I also profiled it for this file, it is as fast as it gets,
self.time: 0.00,self.pct: 0.00. :)