Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODOs related to {waldo} update #1518

Merged
merged 10 commits into from
Sep 19, 2022
Merged

Remove TODOs related to {waldo} update #1518

merged 10 commits into from
Sep 19, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico I am not sure which test this is referring to:

# TODO(michaelchirico): use plain expect_equal after waldo#133 makes it into a CRAN release
# Here, the environment()s are different because factories use them.

That's the only TODO that remains related to the {waldo} update.

@MichaelChirico
Copy link
Collaborator

IINM that TODO's referring to this:

expect_silent(result <- all.equal(linters_with_tags("default"), linters_with_defaults()))
expect_true(result)

@IndrajeetPatil IndrajeetPatil added this to the 3.0.2 milestone Sep 13, 2022
@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico This should be ready for approval now.

@MichaelChirico MichaelChirico merged commit 13f00c2 into main Sep 19, 2022
@MichaelChirico MichaelChirico deleted the waldo_todo branch September 19, 2022 08:16
@MichaelChirico MichaelChirico modified the milestones: 3.0.3, 3.1.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants