Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and adds tests for Quarto files #1487

Merged
merged 26 commits into from
Sep 29, 2022
Merged

Update docs and adds tests for Quarto files #1487

merged 26 commits into from
Sep 29, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #1486

@IndrajeetPatil

This comment was marked as resolved.

@IndrajeetPatil IndrajeetPatil requested review from MichaelChirico and AshesITR and removed request for MichaelChirico July 29, 2022 14:12
@AshesITR
Copy link
Collaborator

AshesITR commented Jul 29, 2022

Not sure if that's the reason, but trim_some() is supposed to be called like this:

trim_some('
  ---
  title: "bla"
  ---

  Content
')

Mind the location of the quotes.

Also note that knitr format detection is possibly dependent on the version of knitr that is installed.

@IndrajeetPatil
Copy link
Collaborator Author

IndrajeetPatil commented Jul 29, 2022

This is the problem.

For .qmd, the code in question leads to an error (and therefore 2 lints are produced):

Screenshot 2022-07-29 at 18 47 54

For .Rmd, no error:

Screenshot 2022-07-29 at 18 48 30

So, I can just drop this test for .qmd.

@IndrajeetPatil IndrajeetPatil added this to the 3.0.1 milestone Jul 30, 2022
NEWS.md Outdated Show resolved Hide resolved
@IndrajeetPatil IndrajeetPatil requested review from AshesITR and removed request for AshesITR August 7, 2022 05:52
@IndrajeetPatil IndrajeetPatil marked this pull request as draft August 26, 2022 12:03
@IndrajeetPatil IndrajeetPatil changed the title Updates docs and adds tests for Quarto files WIP: Updates docs and adds tests for Quarto files Aug 26, 2022
@IndrajeetPatil IndrajeetPatil removed this from the 3.0.1 milestone Aug 26, 2022
@IndrajeetPatil IndrajeetPatil changed the title WIP: Updates docs and adds tests for Quarto files Update docs and adds tests for Quarto files Sep 27, 2022
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review September 27, 2022 09:38
@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico I've marked this as ready for review. I wanted to wait for issue with unexecuted code blocks to be resolved (cf. #1486 (comment)), but that is too open-ended to block this PR.

@IndrajeetPatil IndrajeetPatil merged commit 67234eb into main Sep 29, 2022
@IndrajeetPatil IndrajeetPatil deleted the qmd_tests branch September 29, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure Quarto files (.qmd) are supported
4 participants