Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits to docs for linters #1480

Merged
merged 28 commits into from
Sep 19, 2022
Merged

Edits to docs for linters #1480

merged 28 commits into from
Sep 19, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Jul 28, 2022 •
edited
Loading

  • Where the text description wasn't clear, adds a small example
  • Consistent formatting of function calls or names as code in Roxygen docs to distinguish it from text
  • Grammar or spelling corrections

@IndrajeetPatil IndrajeetPatil added this to the 3.0.1 milestone Jul 28, 2022
@IndrajeetPatil IndrajeetPatil changed the title Edits to docs for linters WIP: Edits to docs for linters Jul 28, 2022
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review July 28, 2022 20:03
@IndrajeetPatil IndrajeetPatil changed the title WIP: Edits to docs for linters Edits to docs for linters Jul 28, 2022
MichaelChirico
MichaelChirico reviewed Jul 31, 2022
View reviewed changes
R/commas_linter.R Outdated Show resolved Hide resolved
@IndrajeetPatil IndrajeetPatil mentioned this pull request Aug 3, 2022
Closed
78 tasks
@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico All review comments are resolved here now. Let me know if you had any additional comments/concerns.

@IndrajeetPatil IndrajeetPatil requested review from AshesITR and removed request for AshesITR August 9, 2022 05:57
@IndrajeetPatil
Copy link
Collaborator Author

I am waiting for this to be merged before I can work on #1492; I think there aren't any unresolved review comments here.

@IndrajeetPatil
Copy link
Collaborator Author

bump

@IndrajeetPatil IndrajeetPatil changed the title Edits to docs for linters WIP: Edits to docs for linters Aug 28, 2022
@IndrajeetPatil IndrajeetPatil marked this pull request as draft August 28, 2022 19:42
@IndrajeetPatil IndrajeetPatil removed this from the 3.0.1 milestone Aug 28, 2022
@IndrajeetPatil IndrajeetPatil changed the title WIP: Edits to docs for linters Edits to docs for linters Sep 13, 2022
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review September 13, 2022 15:23
@IndrajeetPatil IndrajeetPatil added this to the 3.0.2 milestone Sep 13, 2022
MichaelChirico
MichaelChirico approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaelChirico MichaelChirico merged commit b9f0123 into main Sep 19, 2022
@MichaelChirico MichaelChirico deleted the doc_edits_301 branch September 19, 2022 07:12
@MichaelChirico MichaelChirico modified the milestones: 3.0.3, 3.1.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

@AshesITR AshesITR Awaiting requested review from AshesITR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IndrajeetPatil @AshesITR @MichaelChirico