yoda test linter doesnt lint on expect_equal(x$"key", 2) #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle pipe-terminal tests in yoda linter * customize yoda_test_linter message for placeholder tests (#1070) * customize yoda_test_linter message for placeholder tests * fix indentation Co-authored-by: AshesITR <alexander.rosenstock@web.de> Co-authored-by: AshesITR <alexander.rosenstock@web.de>
MichaelChirico
added a commit
that referenced
this pull request
Apr 25, 2022
* use xml-based check for yoda_test_linter Branch comparison crashing a bunch because of failing on unparseable files -- this is why * yoda test linter doesnt lint on expect_equal(x$"key", 2) (#1068) * yoda test linter doesnt lint on expect_equal(x$"key", 2) * handle pipe-terminal tests in yoda linter (#1069) * handle pipe-terminal tests in yoda linter * customize yoda_test_linter message for placeholder tests (#1070) * customize yoda_test_linter message for placeholder tests * fix indentation Co-authored-by: AshesITR <alexander.rosenstock@web.de> Co-authored-by: AshesITR <alexander.rosenstock@web.de> Co-authored-by: AshesITR <alexander.rosenstock@web.de> Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067
Based against #1065 for now.