Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RStudio: no more linters, pane "Markers" stays #520

Closed
razz-matazz opened this issue Sep 11, 2020 · 4 comments · Fixed by #521
Closed

RStudio: no more linters, pane "Markers" stays #520

razz-matazz opened this issue Sep 11, 2020 · 4 comments · Fixed by #521

Comments

@razz-matazz
Copy link

Hello,

When lintering a file in RStudio, a pane "Markers" opens and displays the linters. Fine.
When lintering the file again, the pane refreshes. As long as linters are found. If not, the pane doesn't refresh (or close).

RStudio version 1.3.1056, Windows 10.

@AshesITR
Copy link
Collaborator

Thanks for reporting this. I've looked into it and confirmed the problem:
The issue is with the conditional if (length(x)) in print.lints.

https://github.com/jimhester/lintr/blob/630cc228c62e35ea59c2d5bc3f9812a506a30d5e/R/methods.R#L53-L81

The implementation of rstudio_source_markers() could handle empty lints.

@AshesITR
Copy link
Collaborator

@razz-matazz Do you mind checking out the branch in PR #521 to confirm the bug is fixed for you as welll?
Thanks!

@razz-matazz
Copy link
Author

i'd love to do so, but never checked out a branch/reviewed a PR... Do you know any guide I can follow?

@AshesITR
Copy link
Collaborator

You can specify the commit in remotes::install_github().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants