Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing row numbers in available_linters() data frame #1781

Closed
yousefmustafa opened this issue Nov 30, 2022 · 5 comments · Fixed by #1813
Closed

Missing row numbers in available_linters() data frame #1781

yousefmustafa opened this issue Nov 30, 2022 · 5 comments · Fixed by #1813
Labels
bug an unexpected problem or unintended behavior

Comments

@yousefmustafa
Copy link

When available_linters() is saved as a data frame, it has 73 observations/rows, however the last row in the data frame is named as "77". I checked and the following row names are missing from the availabe_linters() data frame: 8, 47, 51, 58. Is there a specific reason why those row names are skipped in available_linters()? Just pointing this out in case it's a bug

@IndrajeetPatil
Copy link
Collaborator

IndrajeetPatil commented Nov 30, 2022

Haven't looked closely yet, but it might be due to the deprecated linters.

@yousefmustafa
Copy link
Author

It's not that big of an issue as I've just been resetting the row names locally to make sure the row number and linter name match each other. I just pointed out the issue in case it had been overlooked. Thanks!

@AshesITR
Copy link
Collaborator

Is there a specific reason why you are using the row names, or just a curiosity?
Regardless, we should reset the row names on our end - thanks for reporting!

@AshesITR AshesITR added the bug an unexpected problem or unintended behavior label Nov 30, 2022
@yousefmustafa
Copy link
Author

Since you asked why I'm using row names...I'm attempting to make a package in which available_linters() is printed in the console, and then the user can input the row numbers of the specific linters they want to use, and then the package lints based on that input. If the row labels of the available_linters() data frame don't match the actual row indices, then the incorrect linters are selected. I hope my explanation makes sense. It's not the most elegant attempt at using lintr, but it's where I'm at right now. Thanks for the help!

@AshesITR
Copy link
Collaborator

Sounds cool, thanks for sharing 😊

IndrajeetPatil added a commit that referenced this issue Dec 8, 2022
IndrajeetPatil added a commit that referenced this issue Dec 8, 2022
* Fix missing row names in `available_linters()`

Closes #1781

* Update linter_tags.R

* add another test

* address review comments

* reword NEWS bullet

Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants