Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semicolons at the end of the line? #147

Closed
gaborcsardi opened this issue May 12, 2016 · 4 comments
Closed

Semicolons at the end of the line? #147

gaborcsardi opened this issue May 12, 2016 · 4 comments

Comments

@gaborcsardi
Copy link
Member

Would you like to see a PR for it?
@jimhester
Copy link
Member

Sure, that is a good one actually!

@gaborcsardi
Copy link
Member Author

How about non-trailing semicolons? Personally I think that these are quite often fine, but sometimes not.
Should we report these? Have a separate linter for them? Ignore them completely?

@jimhester
Copy link
Member

I think non trailing are fine as well
On May 12, 2016 8:42 AM, "Gábor Csárdi" notifications@github.com wrote:

How about non-trailing semicolons? Personally I think that these are quite
often fine, but sometimes not.
Should we report these? Have a separate linter for them? Ignore them
completely?

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#147 (comment)

jimhester added a commit that referenced this issue May 12, 2016
@jimhester
Merge pull request #148 from gaborcsardi/trailing-semicolon
2b091a8 
trailing_semicolon_linter #147
@gaborcsardi
Copy link
Member Author

Closed by #148.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimhester @gaborcsardi