Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump withr dependency to 2.5.0 and use local_tempfile(lines = ) in tests #1404

Closed
MichaelChirico opened this issue Jun 17, 2022 · 0 comments · Fixed by #1412
Closed

Bump withr dependency to 2.5.0 and use local_tempfile(lines = ) in tests #1404

MichaelChirico opened this issue Jun 17, 2022 · 0 comments · Fixed by #1412
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible

Comments

@MichaelChirico
Copy link
Collaborator

This is a convenient improvement to local_tempfile() that's available since withr 2.5.0 on CRAN since March. By the time we release again, it should be mature enough that we are happy to depend on it.

Originally posted by @MichaelChirico in #1403 (comment)

@MichaelChirico MichaelChirico added the internals Issues related to inner workings of lintr, i.e., not user-visible label Jun 17, 2022
MichaelChirico pushed a commit that referenced this issue Jun 19, 2022
* Bump needed `{withr}` version

In order to use the `lines` parameter from `withr::local_tempfile()`.

Closes #1404

* empty file

* Update test-get_source_expressions.R

* rest of it

* Revert "rest of it"

This reverts commit a6a6e2c.

* rest of it

* fix indentation

Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant