missing_argument_linter() allows missing arguments in quote() cal…

…ls (#1890) Closes #1889
r-lib · Jan 5, 2023 · bb4d43d · bb4d43d
1 parent 6d892a3
commit bb4d43d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -96,6 +96,8 @@
 
 * `all_linters()` function provides an easy way to access all available linters (#1843, @IndrajeetPatil)
 
+* `missing_argument_linter()` allows missing arguments in `quote()` calls (#1889, @IndrajeetPatil). 
+
 ### New linters
 
 * `unnecessary_lambda_linter()`: detect unnecessary lambdas (anonymous functions), e.g.

diff --git a/R/missing_argument_linter.R b/R/missing_argument_linter.R
@@ -31,7 +31,7 @@
 #' @evalRd rd_tags("missing_argument_linter")
 #' @seealso [linters] for a complete list of linters available in lintr.
 #' @export
-missing_argument_linter <- function(except = c("switch", "alist"), allow_trailing = FALSE) {
+missing_argument_linter <- function(except = c("alist", "quote", "switch"), allow_trailing = FALSE) {
   conds <- c(
     "self::OP-COMMA[preceding-sibling::*[not(self::COMMENT)][1][self::OP-LEFT-PAREN or self::OP-COMMA]]",
     "self::EQ_SUB[following-sibling::*[not(self::COMMENT)][1][self::OP-RIGHT-PAREN or self::OP-COMMA]]"

diff --git a/man/missing_argument_linter.Rd b/man/missing_argument_linter.Rd
diff --git a/tests/testthat/test-missing_argument_linter.R b/tests/testthat/test-missing_argument_linter.R
@@ -8,6 +8,7 @@ test_that("missing_argument_linter skips allowed usages", {
   expect_lint("array[, , 1]", NULL, linter)
   expect_lint("switch(a =, b =, c = 1, 0)", NULL, linter)
   expect_lint("alist(a =, b =, c = 1, 0)", NULL, linter)
+  expect_lint("pairlist(path = quote(expr = ))", NULL, linter) #1889
 
   expect_lint("test(a =, b =, c = 1, 0)", NULL, missing_argument_linter("test"))
 })