feat: New generics to support Arrow-compatible backends #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love the name of the new generic! |
krlmlr
reviewed
Sep 19, 2022
There was a problem hiding this comment.
Thanks, this looks great. Apart from the inline comments, the naming choice for dbWriteStream() and dbStreamTable() seems inconsistent. Would dbWriteTableArrow() and dbReadTableArrow(), along with dbAppendTableArrow(), and dbCreateTableArrow(), be too boring?
The latter two could be descoped for now, but we should definitely add them later so that backends don't necessarily need to override dbWriteTableArrow() .
|
Did we agree to add tests to DBItest? |
|
Missing in this PR, should be part of a later PR:
|
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krlmlr How do you feel about this? Happy to discuss.