Bring forward 2.0 html raster refactoring with Monocle #632

tresf · 2020-05-07T17:51:00Z

Brings forward all race condition fixes (and performance improvement fixes) from #580 with Monocle as a headless HTML engine.

This PR supercedes #623.

+ fix existing zoom/scaling issues

… blanks on successive pages

tresf · 2020-05-07T17:57:36Z

src/qz/printer/action/WebApp.java

-            try { Thread.sleep(SLEEP); } catch(Exception ignore) {}
+                    //software rendering required headless environments
+                    if (PrintSocketServer.isHeadless()) {
+                        System.setProperty("prism.order", "sw");


Quoting the private bug tracker:

There is 1 thing that is still open: rendering on Linux with es2 (instead of sw) and Monocle. Should be doable to fix though.
...
rendering on Linux with es2 and Monocle is now working. Need to modify build procedures.

Interestingly, this passed in #586, so I'm not sure what the stability impact of this is to Linux.

Gluon explains that this is likely due to the fallback order and that it's very likely it would still work. Anyway, they provided a new build with this patched, we just need to update the gluon binaries.

klabarge · 2020-05-09T00:37:48Z

On macOS there's no dialogue warning (about restarting QZ Tray) when clicking "Use Monocle for HTML".

I ran this is in IntelliJ but I don't see any errors.

Environment:

macOS 10.15.4
AdoptOpenJDK 11.0.6

klabarge · 2020-05-09T01:00:36Z

On Windows 10 using Java 8u211 HTML printing with rasterize: false has much different results than 2.1.1

mono-fastforward

2.1.0

akberenz · 2020-05-12T04:07:34Z

@klabarge, what printer settings are you using, and are you using any other options in QZ for the print?
I tried with both j8u202 (what I had onhand) and then updated to the latest j8u251 and am getting the expected results with both.

klabarge · 2020-05-12T22:07:22Z

and are you using any other options in QZ for the print?

@bberenz I'm using the sample.html for testing.
I can reproduce using this config: var config = qz.configs.create("PDFCreator", { rasterize: true, scaleContent: true});

[DEBUG] 2020-05-12 18:03:03,579 @ qz.ws.PrintSocketClient:?
	Message: {"call":"print","promise":{},"params":{"printer":{"name":"PDFCreator"},"options":{"bounds":null,"colorType":"color","copies":1,"density":0,"duplex":false,"fallbackDensity":null,"interpolation":"bicubic","jobName":null,"legacy":false,"margins":0,"orientation":null,"paperThickness":null,"printerTray":null,"rasterize":true,"rotation":0,"scaleContent":true,"size":null,"units":"in","altPrinting":false,"encoding":null,"endOfDoc":null,"perSpool":1},"data":[{"type":"pixel","format":"html","flavor":"plain","data":"<html><body>  <table style=\"font-family: monospace; width: 100%\">    <tr>      <td>        <h2>* QZ Tray HTML Sample Print *</h2>        <span style=\"color: #D00;\">Version:</span> 2.1.0<br/>        <span style=\"color: #D00;\">Source:</span> https://qz.io/      </td>      <td align=\"right\">        <img src=\"file:///C:/Program%20Files/QZ%20Tray/demo/assets/img/image_sample.png\" />      </td>    </tr>  </table></body></html>","options":{"pageWidth":"","pageHeight":""}}]},"timestamp":1589320983570,"uid":"dhltt7","signAlgorithm":"SHA512","position":{"x":720,"y":430}}
[WARN] 2020-05-12 18:03:03,584 @ qz.ws.PrintSocketClient:?
	Bad signature on request
[DEBUG] 2020-05-12 18:03:03,602 @ qz.common.TrayManager:?
	Calculated dialog centered at: java.awt.Point[x=1293,y=762]
[INFO] 2020-05-12 18:03:04,854 @ qz.common.TrayManager:?
	Allowed localhost to print to PDFCreator
[TRACE] 2020-05-12 18:03:04,855 @ qz.utils.PrintingUtilities:?
	Waiting for processor, 0/1 already in use
[DEBUG] 2020-05-12 18:03:04,855 @ qz.utils.PrintingUtilities:?
	Using qz.printer.action.PrintHTML to print
[DEBUG] 2020-05-12 18:03:04,857 @ qz.printer.PrintServiceMatcher:?
	Searching for PrintService matching PDFCreator
[DEBUG] 2020-05-12 18:03:04,857 @ qz.printer.PrintServiceMatcher:?
	Found 9 printers
[DEBUG] 2020-05-12 18:03:04,858 @ qz.printer.PrintServiceMatcher:?
	Found match: PDFCreator
[DEBUG] 2020-05-12 18:03:04,903 @ qz.printer.action.PrintHTML:?
	Parsed 1 html records
[TRACE] 2020-05-12 18:03:04,911 @ qz.printer.action.WebApp:?
	Waiting on capture..
[TRACE] 2020-05-12 18:03:04,951 @ qz.printer.action.WebApp:?
	Setting starting size 6800.000000000001:0.0
[TRACE] 2020-05-12 18:03:04,983 @ qz.printer.action.WebApp:?
	Done: 100.0 > -1.0
[TRACE] 2020-05-12 18:03:04,984 @ qz.printer.action.WebApp:?
	New state: SUCCEEDED > READY
[TRACE] 2020-05-12 18:03:04,985 @ qz.printer.action.WebApp:?
	Done: -1.0 > 0.0
[TRACE] 2020-05-12 18:03:04,985 @ qz.printer.action.WebApp:?
	New state: READY > SCHEDULED
[TRACE] 2020-05-12 18:03:04,986 @ qz.printer.action.WebApp:?
	New state: SCHEDULED > RUNNING
[TRACE] 2020-05-12 18:03:04,992 @ qz.printer.action.WebApp:?
	Done: 0.0 > 100.0
[TRACE] 2020-05-12 18:03:04,993 @ qz.printer.action.WebApp:?
	New state: RUNNING > SUCCEEDED
[TRACE] 2020-05-12 18:03:04,994 @ qz.printer.action.WebApp:?
	Setting HTML page height to 850.0000000000001
[WARN] 2020-05-12 18:03:04,995 @ qz.printer.action.WebApp:?
	Zoom level 8.333333333333334 decreased to 3.0292823787332543 due to physical memory limitations
[TRACE] 2020-05-12 18:03:04,997 @ qz.printer.action.WebApp:?
	Zooming in by x3.0292823787332543 for increased quality
[DEBUG] 2020-05-12 18:03:05,014 @ qz.printer.action.WebApp:?
	Attempting image capture
[TRACE] 2020-05-12 18:03:05,534 @ qz.printer.action.PrintPixel:?
	DPI: [600.0x600.0]	CNV: 72.0
[TRACE] 2020-05-12 18:03:05,534 @ qz.printer.action.PrintPixel:?
	Drawable area: 0.0,0.0:8.5,11.0
[TRACE] 2020-05-12 18:03:05,535 @ qz.printer.action.PrintPixel:?
	[one-sided, (0.0,0.0)->(215.9,279.4)mm, color, 60000x60000 dphi]
[INFO] 2020-05-12 18:03:05,557 @ qz.printer.action.PrintPixel:?
	Starting printing (1 copies)
[TRACE] 2020-05-12 18:03:05,712 @ qz.printer.action.PrintImage:?
	Requested page 0 for printing
[TRACE] 2020-05-12 18:03:05,750 @ qz.printer.action.PrintImage:?
	Requested page 0 for printing
[DEBUG] 2020-05-12 18:03:05,761 @ qz.printer.action.PrintImage:?
	No need to upscale image
[DEBUG] 2020-05-12 18:03:05,761 @ qz.printer.action.PrintImage:?
	Paper area: 0,0:612,792
[TRACE] 2020-05-12 18:03:05,763 @ qz.printer.action.PrintImage:?
	Image size: 612.0,76.5
[TRACE] 2020-05-12 18:03:05,764 @ qz.printer.action.PrintImage:?
	{Image interpolation method key=Bicubic image interpolation mode, Stroke normalization control key=Pure stroke conversion for accurate paths, Text-specific antialiasing enable key=Antialiased text mode, Color rendering quality key=Highest quality color rendering mode, Global antialiasing enable key=Antialiased rendering mode, Alpha blending interpolation method key=Highest quality alpha blending methods, Fractional metrics enable key=Integer text metrics mode, Dithering quality key=Default dithering mode, Global rendering quality key=Highest quality rendering methods, Text-specific LCD contrast key=140}
[DEBUG] 2020-05-12 18:03:05,793 @ qz.printer.action.PrintImage:?
	Memory: 225m/910m
[INFO] 2020-05-12 18:03:05,910 @ qz.utils.PrintingUtilities:?
	Printing complete
[TRACE] 2020-05-12 18:03:05,912 @ qz.utils.PrintingUtilities:?
	Returning processor back to pool

what printer settings are you using

PDFCreator, set to US Letter.

Incorrect zoom multiplier causing 2nd page to be blank.

src/qz/printer/action/WebApp.java

tresf · 2020-05-19T17:15:40Z

For some reason on Mac the vector unit tests are failing for known sizes. The first page is OK, but the remainders are blank. This issue does NOT occur for fitted sizes.

tresf · 2020-05-19T18:00:20Z

Sizing issue patched via 96b084d, documented via c726cfa. It doesn't make sense and I don't expect this to work everywhere, so I'll test with some more configurations.

tresf · 2020-05-20T21:52:22Z

For rasterize: false, Java 11 with and without Monocle pass. Java 8 passes.

Unfortunately rasterize: true is failing for Java 8. The inconsistent sizing issues that plagued 2.0 seem to have returned with this branch. These results are from Windows 10 + Java 8 using the WebAppTest class:

tresf · 2020-05-20T22:07:30Z

@bberenz I was able to fix this raster issue above by replacing the calls toautosize(WebView webView) with webView.autosize();, but then it reintroduces #516 for vector prints. Can you help make it execute conditionally?

tresf · 2020-05-26T19:27:33Z

Raster prints are fixed with 12c3ca0. Was hitting "Cancelled" CUPS jobs on vector prints, but they've been magically circumvented via 59db6c3.

JavaFX 15ea+3 adds a fix for software rendering, so bumped that via 212ca4e. Will repeat some tests, fast forward and merge.

Berenz added 4 commits April 29, 2020 13:41

Bring forward 2.0 html raster refactoring

37996e2

+ fix existing zoom/scaling issues

Native printing still needs to wait for a frame of animation to avoid…

6861ccc

… blanks on successive pages

Bring monocle changes forward

e0d9d54

Bring forward iterative monocle changes too

51672b2

tresf added the enhancement label May 7, 2020

tresf added this to the 2.1.1 milestone May 7, 2020

tresf commented May 7, 2020

View reviewed changes

tresf added 2 commits May 7, 2020 14:46

Better headless flag detection

bdeb242

Add TODO for Callback

dbeb7b8

tresf mentioned this pull request May 7, 2020

Bring forward 2.0 html raster refactoring #623

Closed

tresf requested a review from klabarge May 7, 2020 19:48

Berenz and others added 3 commits May 13, 2020 21:31

Change in zoom should cause change in webview size

8b01e34

Refactoring around code placement

fafad09

Fix bad height calculation

87575c6

Incorrect zoom multiplier causing 2nd page to be blank.

tresf commented May 15, 2020

View reviewed changes

src/qz/printer/action/WebApp.java Outdated Show resolved Hide resolved

Berenz added 2 commits May 18, 2020 23:47

Remove transform resets from raster path

cfe7513

Add vector print tests

76e0a8a

tresf added 2 commits May 19, 2020 13:53

Fix known vector prints

96b084d

Comment hacky code

c726cfa

Add IDE warning when wrong libs are in-use

aef8d0c

Berenz added 2 commits May 21, 2020 19:42

Only call updatepeer on vector prints

12c3ca0

Wait for vector print jobs before returning

62d1e54

tresf added 3 commits May 26, 2020 12:20

Add arbitrary sleep to fix CUPS cancelled job issue.

59db6c3

Remove hard-coded value

d49ecdf

Bump JavaFX to version 15ea+3

212ca4e

tresf removed the request for review from klabarge May 26, 2020 19:28

Merge branch 'master' into mono-fastforward

4e4812e

tresf merged commit 409be26 into master May 26, 2020

tresf deleted the mono-fastforward branch May 26, 2020 21:05

tresf mentioned this pull request May 26, 2020

Port monocle to 2.1 #625

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring forward 2.0 html raster refactoring with Monocle #632

Bring forward 2.0 html raster refactoring with Monocle #632

tresf commented May 7, 2020 •

edited

Loading

tresf May 7, 2020

tresf May 20, 2020

klabarge commented May 9, 2020

klabarge commented May 9, 2020

akberenz commented May 12, 2020

klabarge commented May 12, 2020

tresf commented May 19, 2020 •

edited

Loading

tresf commented May 19, 2020

tresf commented May 20, 2020 •

edited

Loading

tresf commented May 20, 2020 •

edited

Loading

tresf commented May 26, 2020

Bring forward 2.0 html raster refactoring with Monocle #632

Bring forward 2.0 html raster refactoring with Monocle #632

Conversation

tresf commented May 7, 2020 • edited Loading

tresf May 7, 2020

Choose a reason for hiding this comment

tresf May 20, 2020

Choose a reason for hiding this comment

klabarge commented May 9, 2020

klabarge commented May 9, 2020

akberenz commented May 12, 2020

klabarge commented May 12, 2020

tresf commented May 19, 2020 • edited Loading

tresf commented May 19, 2020

tresf commented May 20, 2020 • edited Loading

tresf commented May 20, 2020 • edited Loading

tresf commented May 26, 2020

tresf commented May 7, 2020 •

edited

Loading

tresf commented May 19, 2020 •

edited

Loading

tresf commented May 20, 2020 •

edited

Loading

tresf commented May 20, 2020 •

edited

Loading