Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependencies optional #620

Merged
merged 7 commits into from
Apr 27, 2020
Merged

Make dependencies optional #620

merged 7 commits into from
Apr 27, 2020

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Apr 20, 2020

The goal is to move all legacy IE11 dependencies to optional dependencies, including RVSP

  • Use native Promise's when available by default
  • Use native Sha256 hashing when available by default
  • Use fetch() over ajax (closes Replace $.ajax with fetch() #369) with IE11 pollyfill

@tresf tresf requested a review from akberenz April 20, 2020 18:17
@tresf
Copy link
Contributor Author

tresf commented Apr 21, 2020

@klabarge using this branch, can you take a look at https://github.com/qzind/tray/wiki/Signing-Messages and prepare the POST example to use fetch()?

@klabarge
Copy link
Member

prepare the POST example to use fetch()?

Sure, I've got untested code here. I'll update the wiki once I've tested

Berenz and others added 2 commits April 23, 2020 23:11
Revert subtle.crypto since we bundle our own hasher
@tresf
Copy link
Contributor Author

tresf commented Apr 24, 2020

Sure, I've got untested code here. I'll update the wiki once I've tested

Great, while you're at it, if you can test this branch (clean) that would be stellar too. It eliminates RSVP, bundles Sha256. qz-tray.js can now be a single JS lib without any dependencies (except maybe older frameworks missing WebSocket or Promise support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace $.ajax with fetch()
2 participants