Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent configuration and output directory #7

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

qyang-nj
Copy link
Owner

@qyang-nj qyang-nj commented Mar 28, 2024

If an app (ios_application) depends on a library (apple_framework), when building the app and the library separately, the libraries will be built twice into different directories. This is because of transition which causes different configurations. A thorough discussion can be found here.

This change ensures when building the app and the library, they will have same transition, thus they will have the same configuration and same output directory.

We can verify this by running bazel cquery //ios/foundations/StringFoundation:StringFoundation --universe_scope=//ios/foundations/StringFoundation:StringFoundation,//ios:AirbnbApp to make sure only one configuration is showing up.

This change requires to have --experimental_output_directory_naming_scheme=diff_against_baseline flag set.

@qyang-nj qyang-nj merged commit f85c820 into airbnb Mar 28, 2024
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant