Ensure consistent configuration and output directory #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app (
ios_application
) depends on a library (apple_framework
), when building the app and the library separately, the libraries will be built twice into different directories. This is because of transition which causes different configurations. A thorough discussion can be found here.This change ensures when building the app and the library, they will have same transition, thus they will have the same configuration and same output directory.
We can verify this by running
bazel cquery //ios/foundations/StringFoundation:StringFoundation --universe_scope=//ios/foundations/StringFoundation:StringFoundation,//ios:AirbnbApp
to make sure only one configuration is showing up.This change requires to have
--experimental_output_directory_naming_scheme=diff_against_baseline
flag set.