Skip to content
This repository was archived by the owner on Mar 20, 2025. It is now read-only.

Skip call manager test on macos #499

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Oct 16, 2022

  • Clean up CallManager test
  • Skip call manager tests on macOS

PR check list:

  • Document your code
  • Add \since QXmpp 1.X, QXMPP_EXPORT
  • Fix doxygen warnings (see log when building with -DBUILD_DOCUMENTATION=ON)
  • Update doc/doap.xml
  • Add unit tests
  • Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

@lnjX lnjX added the section:tests Unit/integration testing label Oct 16, 2022
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 68.50% // Head: 68.50% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1dbd761) compared to base (19c9d12).
Patch coverage: 87.50% of modified lines in pull request are covered.

❗ Current head 1dbd761 differs from pull request most recent head 7d95f33. Consider uploading reports for the commit 7d95f33 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   68.50%   68.50%   -0.01%     
==========================================
  Files         292      292              
  Lines       25673    25674       +1     
==========================================
  Hits        17587    17587              
- Misses       8086     8087       +1     
Impacted Files Coverage Δ
tests/qxmppcallmanager/tst_qxmppcallmanager.cpp 98.30% <87.50%> (-1.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lnjX lnjX force-pushed the skip-call-manager-macos branch from 7d95f33 to 1dbd761 Compare October 16, 2022 13:13
@lnjX lnjX merged commit ecce762 into qxmpp-project:master Oct 16, 2022
@lnjX lnjX changed the title skip call manager macos Skip call manager test on macos Oct 16, 2022
@lnjX lnjX deleted the skip-call-manager-macos branch August 13, 2023 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
section:tests Unit/integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant