Add support for time dependent expressions in transformations. #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables time dependent expressions for arithmetic pulse templates.
…nel transformation to reflect that it allows time dependent channels
5 tasks
shumpohl
commented
Dec 5, 2022
| @@ -362,6 +371,23 @@ def test_get_transformation(self): | |||
| expected_trafo = ScalingTransformation(inv_scalar) | |||
| self.assertEqual(expected_trafo, trafo) | |||
|
|
|||
| def test_time_dependent_expression(self): | |||
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea was to enable time dependent expressions for arithmetic pulse templates. However this will not produce reasonable results when the other PT is not atomic because the waveform i.e. the transformation will not get the correct time during sampling of a composite PT.
One could circumvent this by adding a time delay for SequencePT and ForLoopPT but if there is a RepetitionPT it cannot be handled correctly because the waveform itself is not actually repeated i.e. it needs to be unrolled.
We could adapt the
Programtype to be more powerful and cover the representation of a modulated or otherwise altered sub-program. This could allow efficient playback on supporting hardware.The current solution is to enforce atomicity via the newly added
_is_atomicmethod.Examples will be added in a separate PR.