Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

[BUG] Ayah play button not working #383

Closed
thabti opened this issue Jul 9, 2016 · 6 comments
Closed

[BUG] Ayah play button not working #383

thabti opened this issue Jul 9, 2016 · 6 comments

Comments

@thabti
Copy link
Contributor

thabti commented Jul 9, 2016 •
edited
Loading

Clicking Play next to the Ayah doesn't work.

screen shot 2016-07-09 at 19 57 45

Would it be possible to introduce a repository project that would hold a set of functional tests? I introduced functional testing using Webdriver.io(JS) at the company I work for. If possible can we setup a repository quran/quran.com-functional-tests. I don't mind owning this.
@mmahalwy
Copy link
Contributor

mmahalwy commented Jul 9, 2016

Yes, that has been known for a while and hasnt worked for a while now :S

@thabti
Copy link
Contributor Author

thabti commented Jul 10, 2016 •
edited
Loading

Ah that's due to it not being implemented https://github.com/quran/quran.com-frontend/blob/develop/src/components/Ayah/index.js#L48

Should be triggering an audio player action.

@thabti
Copy link
Contributor Author

thabti commented Jul 10, 2016

I will submit a PR for this tomorrow inshallah.

@mmahalwy
Copy link
Contributor

Yes. Sounds good!

thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 10, 2016
@thabti
quran#383 refactoring how redux actions and fixing ayah play (WIP)
3893669
thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 10, 2016
@thabti
quran#383 refactoring how redux actions and fixing ayah play (WIP)
20b5b26
thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 10, 2016
@thabti
quran#383 refactoring how redux actions and fixing ayah play (WIP)
d10dccb
thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 10, 2016
@thabti
quran#383 refactoring how redux actions and fixing ayah play (WIP)
0def82e
thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 10, 2016
@thabti
quran#383 refactor out decorators.
6206412
thabti added a commit to thabti/quran.com-frontend that referenced this issue Jul 10, 2016
@thabti
quran#383 hide play from search results.
f0792a5
mmahalwy pushed a commit that referenced this issue Jul 10, 2016
@thabti @mmahalwy
#383 Ayah Play Audio + Redux Refactoring (WIP) (#390)
c2c1e64 
* #383 refactoring how redux actions and fixing ayah play (WIP)

* 383 lint-roller :bowtie:

* #383 refactor out decorators.

* #383 hide play from search results.

* #371 lint-roller :bowtie:

* #371 :scissors

* #371 ✂️
@thabti
Copy link
Contributor Author

thabti commented Jul 11, 2016

Closing as a fix has been pushed to master, awaiting release.

@thabti thabti closed this as completed Jul 11, 2016
@mmahalwy
Copy link
Contributor

thank you!

@harunpehlivan harunpehlivan mentioned this issue Nov 15, 2022
Open
@harunpehlivan harunpehlivan mentioned this issue Nov 28, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thabti @mmahalwy