Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Should not let user select ayah past end of Surah #248

Closed
mmahalwy opened this issue Apr 4, 2016 · 11 comments
Closed

Should not let user select ayah past end of Surah #248

mmahalwy opened this issue Apr 4, 2016 · 11 comments

Comments

@mmahalwy
Copy link
Contributor

mmahalwy commented Apr 4, 2016

For example /1/8 is not possible.
@abiodun0
Copy link
Contributor

is someone working on this?. If no I would love to work on it

@mmahalwy
Copy link
Contributor Author

Salam @abiodun0, no one is currently! Would you like to grab it? How can I help guide you?

@abiodun0
Copy link
Contributor

Wa Alai Kum salam. I am willing to work on it . I have ran npm run dev on the forked repo. But I still do have error generating the main.js file on the repo. Can you help me on setting this up properly on my system?

@abiodun0
Copy link
Contributor

Do I need some sort of secret keys? @mmahalwy

@abiodun0
Copy link
Contributor

I'm contineously having this error. And the page doesn't seem to display well on my localhost @mmahalwy
screen shot 2016-06-13 at 6 49 36 am

@ahmedre
Copy link
Contributor

ahmedre commented Jun 13, 2016 •
edited
Loading

set an environment variable for API_URL to be http://api.quran.com:3000.
make sure you ran npm install and npm run build

not sure about why main.js isn't loading here - will let @mmahalwy chime in

@mmahalwy
Copy link
Contributor Author

@abiodun0 what url are you going to? localhost:8000 or localhost:8001? 8001 is the dev one, not 8000!

@abiodun0
Copy link
Contributor

Jazzakumu Lahu Khairan @ahmedre The npm run build was what I was missing. Yes @mmahalwy I was using localhost:8001. I guess someone has to update the read me. Let me get to work on it. If either of you have time I would need someone to work me through the code and development process

@mmahalwy
Copy link
Contributor Author

@abiodun0 happy to help. But nam run build is not the solution... it is when you're ready to push to production

@abiodun0
Copy link
Contributor

Can you drop your skype id or any IM i can send a message?

@mmahalwy
Copy link
Contributor Author

@abiodun0 you can ping me on google hangouts: mmahalwy@gmail.com

@abiodun0 abiodun0 mentioned this issue Jun 15, 2016
Merged
abiodun0 added a commit to abiodun0/quran.com-frontend that referenced this issue Jun 15, 2016
@abiodun0
(finishes quran#248) handles the surah invalid from the componentWill…
7e4c334 
…Mount
abiodun0 added a commit to abiodun0/quran.com-frontend that referenced this issue Jun 15, 2016
@abiodun0
fixes for quran#248 with respect to @mmahalwy comments
00d94df
abiodun0 added a commit to abiodun0/quran.com-frontend that referenced this issue Jun 15, 2016
@abiodun0
more fixes quran#248
be24d92
mmahalwy added a commit that referenced this issue Jul 10, 2016
@mmahalwy
Develop -> Master (#387)
4395405 
* HOTFIX reading mode markers (#303)

* Default api and files (#306)

* Reducing bundle size (#310)

* Reducing bundle size

* rearranged files

* more rearrange and deleted unneeded files

* add default segments key (#313)

* transitioning to al-quran al-kareem (#314)

transitioning to Al-Quran al-Kareem

* Fix lint issues

* Update Readme.md

* Add devDependency Status

* Update Readme for new developers

* Code splitting assets (#321)

* Code splitting

* Split the html files into their own and ajax requested

* Pass tests

* Wrong files

* Add segments

* Add segments

* Autocomplete pointing to v2 suggest

* HOTFIX pretty-error dep (#323)

* HOTFIX Search to the right route (#324)

* No segments for non-segmented reciters (#325)

* Adding sentry (#327)

* CDN images for surahinfo (#328)

* Reduce data dehydration (#329)

* Search Action on homepage (#330)

* Descriptions for surahs (#331)

* Fixed head tags (#332)

* Head tags improved and more organized

* Fixed the head problem

* audioplayer bug fixes, or more bugs (#335)

* audioplayer bug fixes, or more bugs

* removes some unneeded state things in audioplayer redux, also fixes a bug where event listeners would get bound without properly unbinding multiple times, which caused the player to skip ayahs after using next <-> prev more then once on the same ayah

* temporarily disables word focusing capacity

* Add sourcemaps to prod

* Remove zero padding in urls

* (WIP) Issue #248 (#336)

Fixes #248 Out of range bug

* correct waffle url. (#338)

* JS error on surah click (#349)

* Add Heroku generated app.json

* Ramadan Todo list (#343)

* Change

* Eslint added (#345)

* Eslint added

* eslint in travis

* ayah require

* Fixed

* fixed bug that was preventing ayah transition on audioplayer

* fix autocomplete thing

* Extract connect from the surah container (#347)

* Fout fonts (#346)

* Fout fonts

* wip

* wip2

* do not update

* pass tests

* Sourcemap for sentry (#352)

* contribution guideline (#355)

* Heroku pipeline trials (#354)

* push

* push

* push

* push

* push

* Heroku push (#356)

* Heroku push

* public urls

* Add zendesk widget (#358)

* Fix font artifacts

This fixes #365 by merging the 3 fonts from quran/quran.com-images#7,
quran/quran.com-images#8, and quran/quran.com-images#9.

* Update font for page 237 to fix spacing in 12:17

This fixes the spacing issue in 12:17 by updating the font. Fixes #369.

* Feature/341 social share (#367)

* Add zendesk widget (#358)

*  The first commit's message is:

* Simplify audioplayer (#360)

* Audioplayer refactor

* more reshuffling

* move logic outside of tracker

* fixes #359

* eslint

* refactor and works

* Added segments

* Fix navigating from home to surah

* reciter change

* on word click working!

* segments encryption and lazy decryption

* encryption lib

* linter is happy

* unit tests

* env

* Fix sentry bug (#373)

* Fix sentry bug

* no build

* #372 colon separated surah/ayah (#374)

* #372 colon separated surah/ayah

* #372 colon separated surah/ayah

* #372 colon separated surah/ayah

* Re-output fonts with Apple option enabled

This probably doesn't matter for web, but it may matter for apps in the
future, plus wanted to keep in sync with the versions of the fonts used
by quran/quran.com-images.

* Tooltip options for translation and transliteration (#376)

* Reading mode single line (#377)

* - ayah's have link (discuss, maybe not needed) (#379)

- Fix audio player playing text
- Remove unneeded padding on mobile
- Hide Share on mobile devices (native share is built into the browsers)

* Added Mixpanel (#384)

* Remove footer links (#385)

* Remove footer links

* eslint

* Fix json-ld (#386)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahmedre @mmahalwy @abiodun0