Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arabic Text Rendering in Notes Sharing #650

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

yismailuofa
Copy link
Contributor

Tries to fix the issue with brackets in texts with bidirectional languages by nesting the arabic text with unicode characters

Based off of these Apple Docs
and this Stack Overflow

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-22.at.13.15.32.mp4

@yismailuofa yismailuofa mentioned this pull request Aug 22, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 39.68%. Comparing base (d9fc366) to head (82e6d21).
Report is 12 commits behind head on main.

Files Patch % Lines
Features/NotesFeature/NotesViewModel.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   40.92%   39.68%   -1.25%     
==========================================
  Files         525      526       +1     
  Lines       20880    19439    -1441     
==========================================
- Hits         8546     7715     -831     
+ Misses      12334    11724     -610     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945
Copy link
Collaborator

Oh, this is amazing find. I didn't know about this.

I think this is best suited to be implemented in:

return try await shareableVersePersistence.textForVerse(verse) + "﴿ \(verseNumber)"

This way it will be useful for any sharing functionality not just the notes sharing including sharing or copying quran text from the main quran page.

PS:

@yismailuofa
Copy link
Contributor Author

I think this is best suited to be implemented in ...

Refactored it out and updated the tests to match (and formatted it this time 😅 )

@mohamede1945 mohamede1945 marked this pull request as ready for review August 24, 2024 20:29
@mohamede1945
Copy link
Collaborator

Jazak Allah khyrn! Looks amazing! I'll merge the PR as soon as the CI finishes.

@mohamede1945 mohamede1945 merged commit 8af1fd2 into quran:main Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants