Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate quran image to SwiftUI #633

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Migrate quran image to SwiftUI #633

merged 3 commits into from
Apr 6, 2024

Conversation

mohamede1945
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 35.18072% with 269 lines in your changes are missing coverage. Please review.

Project coverage is 40.93%. Comparing base (c447d28) to head (2c36dbc).

Files Patch % Lines
...I/NoorUI/Features/Quran/ImageDecorationsView.swift 0.00% 63 Missing ⚠️
...oorUI/Features/Quran/AdaptiveImageScrollView.swift 0.00% 49 Missing ⚠️
...ures/QuranImageFeature/ContentImageViewModel.swift 0.00% 48 Missing ⚠️
Features/QuranImageFeature/ContentImageView.swift 0.00% 27 Missing ⚠️
.../UIx/SwiftUI/Miscellaneous/View+onSizeChange.swift 0.00% 16 Missing ⚠️
...QuranImageFeature/ContentImageViewController.swift 0.00% 14 Missing ⚠️
...ReadingSelectorFeature/View/ReadingImageView.swift 0.00% 14 Missing ⚠️
...atures/QuranImageFeature/ContentImageBuilder.swift 0.00% 10 Missing ⚠️
...eadingSelectorFeature/View/Reading+Resources.swift 0.00% 8 Missing ⚠️
...rUI/Miscellaneous/ReadableInsetsViewModifier.swift 0.00% 5 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   40.49%   40.93%   +0.43%     
==========================================
  Files         526      525       -1     
  Lines       21039    20880     -159     
==========================================
+ Hits         8520     8547      +27     
+ Misses      12519    12333     -186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit d9fc366 into main Apr 6, 2024
3 checks passed
@mohamede1945 mohamede1945 deleted the afifi branch April 6, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant