Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix observation of UserDefaults #605

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix observation of UserDefaults #605

merged 1 commit into from
Dec 10, 2023

Conversation

mohamede1945
Copy link
Collaborator

Make Preferences is the only way to CRUD user defaults and use custom observation in Preferences class.

Make Preferences is the only way to CRUD user defaults and
use custom observation in Preferences class.
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4060f8f) 41.78% compared to head (dbba2a1) 41.79%.

Files Patch % Lines
Core/Preferences/Preference.swift 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   41.78%   41.79%           
=======================================
  Files         505      505           
  Lines       19612    19593   -19     
=======================================
- Hits         8194     8188    -6     
+ Misses      11418    11405   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit 8e945f2 into main Dec 10, 2023
2 checks passed
@mohamede1945 mohamede1945 deleted the afifi branch December 10, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant