Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support room versioning #233

Closed
KitsuneRal opened this issue Aug 25, 2018 · 2 comments
Closed

Support room versioning #233

KitsuneRal opened this issue Aug 25, 2018 · 2 comments
Assignees
@KitsuneRal
Labels
enhancement A feature or change request for the library

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Aug 25, 2018 •
edited
Loading

See matrix-org/matrix-spec-proposals#1425 and matrix-org/matrix-spec-proposals#1516. Room upgrading is out of scope of this issue.
@KitsuneRal KitsuneRal mentioned this issue Aug 25, 2018
Closed
@KitsuneRal KitsuneRal self-assigned this Aug 25, 2018
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Aug 25, 2018
@KitsuneRal
Copy link
Member Author

KitsuneRal commented Aug 25, 2018 •
edited
Loading

The support in this case boils down to the following:

  • Create the list of supported API versions within the library (and maintain it from now on)
  • Add room_version to CreateRoomJob (this should come automatically due to Specify how room versioning works matrix-org/matrix-spec-proposals#1516) and Connection::createRoom; the latter should correspond the omitted room version with the highest one supported by the library and the server (I suspect a gap in CS API here for now). (Done in e9ace5c)
  • Avoid processing rooms with unsupported versions (the rooms should be added to the list of connections and some basic state events like name and canonical alias should be parsed but no further processing should be done; depends on Support m.room.create #234).
  • Propagate to clients an error from joining a room the version of which the server doesn't support (M_UNSUPPORTED_ROOM_VERSION). (Done in 20e4f76)

This was referenced Aug 25, 2018
Closed
Closed
KitsuneRal added a commit that referenced this issue Feb 9, 2019
@KitsuneRal
Connection::createRoom: support passing a room version
2dc784d 
On the path to address #233.
KitsuneRal added a commit that referenced this issue Feb 11, 2019
@KitsuneRal
Connection::createRoom: support passing a room version
e9ace5c 
On the path to address #233.
@KitsuneRal
Copy link
Member Author

After some time in the field with the mentioned above two of the four items implemented, it looks like the other two are not really helping anything.

@KitsuneRal KitsuneRal moved this to Version 0.5(.x) - Released in libQuotient 1 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: Version 0.5(.x) - Released
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KitsuneRal