Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revise scrollbars and error messages display #765

Merged
merged 2 commits into from
Jan 4, 2025
Merged

fix: revise scrollbars and error messages display #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a922eae
fix: revise markdown block scrollbar style
ACTCD Jan 2, 2025
e9f9b80
fix: correctly display and adjust error messages
ACTCD Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ a,
x-markdown {
display: flex;
flex-direction: column;
overflow: scroll;
overflow: auto;
text-align: left;
gap: var(--gap);
padding: 0 3rem;
Expand Down
2 changes: 1 addition & 1 deletion xcode/App-Shared/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ extension ViewController: UIDocumentPickerDelegate {
logger?.error("\(#function, privacy: .public) - Export failed: \(error)")
let alert = UIAlertController(
title: "Export failed",
message: error.localizedDescription,
message: "\(error)",
preferredStyle: .alert
)
alert.addAction(UIAlertAction(title: "OK", style: .default))
Expand Down
4 changes: 2 additions & 2 deletions xcode/Shared/Logger.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ func USLogFilesExportTo(_ directory: URL) throws -> URL {
enum errType: String {
case notDirectory = "Not a directory URL"
case logDirURLNil = "Failed get logDirURL"
case noLogDir = "Log directory does not exist"
case noLogFiles = "The log directory is empty"
case noLogDir = "The log is not ready, please try again later (d)"
case noLogFiles = "The log is not ready, please try again later (f)"
case exportFailed = "Export failed"
}
let type: errType
Expand Down
Loading