Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run quinn-udp tests with fast-apple-datapath #2130

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Jan 9, 2025

I suggest we test the feature introduced in #1993 on CI.


Related, we are currently integrating it into Neqo (mozilla/neqo#2302). On our localhost Download benchmark it shows ~10% throughput improvement.

@djc
Copy link
Member

djc commented Jan 9, 2025

Ohh, beta ICEd in CI -- filed.

@gretchenfrage
Copy link
Collaborator

Would it make sense to only run it with this feature on macos, rather than both without and with?

@Ralith
Copy link
Collaborator

Ralith commented Jan 10, 2025

IIRC we're deliberately supporting both cases, since the fast path is a bit sketchy.

@gretchenfrage
Copy link
Collaborator

FWIW, the compiler bug also manifested from me rebasing #1912 over main. https://github.com/quinn-rs/quinn/actions/runs/12700393147/job/35402953810

@djc
Copy link
Member

djc commented Jan 10, 2025

@Ralith did you want to review this?

@mxinden
Copy link
Collaborator Author

mxinden commented Jan 10, 2025

Would it make sense to only run it with this feature on macos, rather than both without and with?

IIRC we're deliberately supporting both cases, since the fast path is a bit sketchy.

Agreed. Long term we might be able to remove the not(fast-apple-datapath). But that needs rigorous testing of fast-apple-datapath first. Releasing this to Firefox Nightly will be a good first step.

@djc djc enabled auto-merge January 10, 2025 16:30
@djc djc disabled auto-merge January 10, 2025 18:49
@djc djc merged commit 3c3d460 into quinn-rs:main Jan 10, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants