Skip to content

Support relative paths in %include_hex() #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2024
Merged

Support relative paths in %include_hex() #147

merged 3 commits into from
May 25, 2024

Conversation

gumb0
Copy link
Contributor

@gumb0 gumb0 commented May 25, 2024 •
edited
Loading

Currently only absolute paths work, unlike in %include and %import

@gumb0 gumb0 changed the title Supprt relative paths in %include_hex() Support relative paths in %include_hex() May 25, 2024
SamWilsn
SamWilsn reviewed May 25, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test for directory traversal, like this?

@gumb0 gumb0 force-pushed the inlcude-hex-fix branch from ccf9368 to 68a9fe6 Compare May 25, 2024 18:47
@gumb0
Copy link
Contributor Author

gumb0 commented May 25, 2024

Would you mind adding a test for directory traversal, like this?

Added.

@gumb0 gumb0 force-pushed the inlcude-hex-fix branch from 68a9fe6 to d617b4c Compare May 25, 2024 19:33
@gumb0
Copy link
Contributor Author

gumb0 commented May 25, 2024

Fixed accidental formatting change.

@SamWilsn SamWilsn merged commit 0f3f681 into quilt:master May 25, 2024
3 checks passed
@gumb0 gumb0 deleted the inlcude-hex-fix branch May 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gumb0 @SamWilsn