Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes TokenStream chain. #1283

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Removes TokenStream chain. #1283

merged 1 commit into from
Feb 21, 2022

Conversation

fulmicoton
Copy link
Collaborator

This change is mostly motivated by the introduction of json object.

We need to be able to inject a position object to make the position
shift.

This change is mostly motivated by the introduction of json object.

We need to be able to inject a position object to make the position
shift.
@codecov-commenter
Copy link

Codecov Report

Merging #1283 (8cd4eea) into main (cef1457) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   94.23%   94.28%   +0.04%     
==========================================
  Files         209      208       -1     
  Lines       35287    35135     -152     
==========================================
- Hits        33253    33127     -126     
+ Misses       2034     2008      -26     
Impacted Files Coverage Δ
src/postings/mod.rs 98.57% <ø> (ø)
src/tokenizer/mod.rs 95.61% <ø> (ø)
src/tokenizer/tokenized_string.rs 77.96% <ø> (-11.89%) ⬇️
src/indexer/segment_writer.rs 92.33% <100.00%> (+0.38%) ⬆️
src/postings/postings_writer.rs 98.17% <100.00%> (+0.10%) ⬆️
src/tokenizer/tokenizer.rs 87.87% <100.00%> (+12.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef1457...8cd4eea. Read the comment docs.

@fulmicoton fulmicoton merged commit 4dc80cf into main Feb 21, 2022
@fulmicoton fulmicoton deleted the no_more_token_stream_chain branch February 21, 2022 00:51
@PSeitz PSeitz mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants