Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening bytes index with dynamic codec #1279

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Feb 18, 2022

Fix #1278

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #1279 (9c12860) into main (505e6a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   94.22%   94.21%   -0.02%     
==========================================
  Files         209      209              
  Lines       35294    35301       +7     
==========================================
+ Hits        33256    33259       +3     
- Misses       2038     2042       +4     
Impacted Files Coverage Δ
src/fastfield/mod.rs 92.94% <ø> (ø)
src/fastfield/reader.rs 88.23% <ø> (-5.89%) ⬇️
src/fastfield/bytes/reader.rs 96.66% <100.00%> (ø)
src/fastfield/readers.rs 86.66% <100.00%> (ø)
src/indexer/index_writer.rs 96.92% <100.00%> (+0.01%) ⬆️
src/indexer/segment_updater.rs 94.55% <0.00%> (+0.12%) ⬆️
src/indexer/segment_manager.rs 82.55% <0.00%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505e6a4...9c12860. Read the comment docs.

@fulmicoton
Copy link
Collaborator

Please add a unit test that failed before and succeeds after @PSeitz

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test plz

@PSeitz
Copy link
Contributor Author

PSeitz commented Feb 18, 2022

I extended the proptest to cover that case and confirmed they fail before

@PSeitz PSeitz requested a review from fulmicoton February 18, 2022 09:43
@PSeitz PSeitz force-pushed the fix_open_bytes_index branch from 79241c9 to 9c12860 Compare February 18, 2022 09:50
@fulmicoton fulmicoton merged commit cef1457 into main Feb 18, 2022
@PSeitz PSeitz mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bytes fastfield codec mismatch
3 participants