Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a bench to measure the perf of indexing logs #1275

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

fulmicoton
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #1275 (9351563) into main (fcd651f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
+ Coverage   94.22%   94.24%   +0.01%     
==========================================
  Files         209      209              
  Lines       35295    35294       -1     
==========================================
+ Hits        33258    33263       +5     
+ Misses       2037     2031       -6     
Impacted Files Coverage Δ
src/indexer/segment_manager.rs 81.20% <0.00%> (-1.35%) ⬇️
src/postings/stacker/expull.rs 93.83% <0.00%> (-0.45%) ⬇️
src/reader/warming.rs 95.19% <0.00%> (-0.03%) ⬇️
src/indexer/index_writer.rs 96.90% <0.00%> (+0.08%) ⬆️
src/fastfield/reader.rs 94.11% <0.00%> (+0.84%) ⬆️
src/indexer/segment_updater.rs 95.46% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd651f...9351563. Read the comment docs.

Copy link
Contributor

@PSeitz PSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hdfs is not a good dataset, because values in the timestamp field are weird

use tantivy::schema::{INDEXED, STRING, TEXT};
use tantivy::Index;

const HDFS_LOGS: &str = include_str!("hdfs.json");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this includes the file in the binary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I know :) but that's the bench binary.

@fulmicoton fulmicoton merged commit 850b9ea into main Feb 18, 2022
@fulmicoton fulmicoton deleted the index-bench branch February 18, 2022 07:48
@PSeitz PSeitz mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants