Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid exposing census::TrackedObject from Warmer API #1264

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Avoid exposing census::TrackedObject from Warmer API #1264

merged 1 commit into from
Jan 25, 2022

Conversation

shikhar
Copy link
Collaborator

@shikhar shikhar commented Jan 24, 2022

neater and more misuse resistant (TrackedObject is Clone)

@shikhar shikhar changed the title Avoid exposing TrackedObject from Warmer API Avoid exposing census::TrackedObject from Warmer API Jan 24, 2022
fulmicoton
fulmicoton approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@fulmicoton fulmicoton merged commit 5a2497b into quickwit-oss:main Jan 25, 2022
@shikhar shikhar deleted the warming-api-census branch January 25, 2022 17:58
This was referenced Feb 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikhar @fulmicoton