Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/922b #1233

Merged
merged 6 commits into from
Dec 10, 2021
Merged

Issue/922b #1233

merged 6 commits into from
Dec 10, 2021

Conversation

fulmicoton
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021 •
edited
Loading

Codecov Report

Merging #1233 (db2392e) into main (c980b19) will increase coverage by 0.05%.
The diff coverage is 98.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
+ Coverage   94.11%   94.16%   +0.05%     
==========================================
  Files         205      206       +1     
  Lines       34468    34821     +353     
==========================================
+ Hits        32439    32790     +351     
- Misses       2029     2031       +2
Impacted Files Coverage Δ
src/fastfield/multivalued/mod.rs 96.96% <ø> (ø)
src/indexer/segment_writer.rs 91.23% <ø> (ø)
src/schema/flags.rs 56.25% <ø> (ø)
src/schema/text_options.rs 95.12% <50.00%> (-4.88%) ⬇️
src/indexer/merger.rs 98.89% <96.87%> (-0.05%) ⬇️
src/core/index_meta.rs 92.89% <100.00%> (ø)
src/core/segment_reader.rs 94.58% <100.00%> (+2.60%) ⬆️
src/fieldnorm/mod.rs 100.00% <100.00%> (ø)
src/fieldnorm/writer.rs 100.00% <100.00%> (ø)
src/indexer/doc_id_mapping.rs 97.01% <100.00%> (+0.26%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c980b19...db2392e. Read the comment docs.

@fulmicoton fulmicoton force-pushed the issue/922b branch 13 times, most recently from 5e81549 to ac568bc Compare December 10, 2021 07:48
Laurent Pouget and others added 6 commits December 10, 2021 18:45
@fulmicoton
Add a NORMED options on field
c1dcf99 
Make fieldnorm indexation optional:

* for all types except text => added a NORMED options
* for text field
** if STRING, field has not fieldnorm retained
** if TEXT, field has fieldnorm computed
@fmassot @fulmicoton
Finalize making fieldnorm optional for all field types.
6019f57
@fulmicoton
CR comments
f3f2047 
- Using Option for fieldnorm readers.
- Fixing the ratio computer. max_doc and not num_doc.
@fulmicoton
Removed fieldnorms from the TermScorer
8453675
@fulmicoton
Set default fieldnorms to true on STRING
3eceedc
@fulmicoton
Edited changelog
827b290
@fulmicoton fulmicoton merged commit c81b303 into main Dec 10, 2021
@fulmicoton fulmicoton deleted the issue/922b branch December 10, 2021 12:12
This was referenced Feb 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulmicoton @codecov-commenter @fmassot