Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare commit #1202

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Prepare commit #1202

merged 2 commits into from
Nov 12, 2021

Conversation

fulmicoton
Copy link
Collaborator

No description provided.

Simplified some of the prepare commit & segment updater code using
async.
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #1202 (a0fe455) into main (7234bef) will increase coverage by 0.02%.
The diff coverage is 88.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   94.04%   94.07%   +0.02%     
==========================================
  Files         205      205              
  Lines       34504    34504              
==========================================
+ Hits        32451    32458       +7     
+ Misses       2053     2046       -7     
Impacted Files Coverage Δ
src/indexer/mod.rs 100.00% <ø> (ø)
src/lib.rs 98.82% <ø> (ø)
src/indexer/index_writer.rs 97.66% <33.33%> (+0.16%) ⬆️
src/indexer/prepared_commit.rs 85.18% <90.90%> (-2.82%) ⬇️
src/indexer/segment_updater.rs 94.97% <93.10%> (+0.25%) ⬆️
src/fastfield/reader.rs 94.06% <0.00%> (-0.85%) ⬇️
src/postings/stacker/expull.rs 93.88% <0.00%> (+0.43%) ⬆️
src/directory/file_watcher.rs 100.00% <0.00%> (+3.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7234bef...a0fe455. Read the comment docs.

@fulmicoton fulmicoton merged commit 8802d12 into main Nov 12, 2021
@fulmicoton fulmicoton deleted the prepare_commit branch November 12, 2021 14:25
This was referenced Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants