fix and refactor log merge policy, fixes #1035 #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
May 18, 2021
fulmicoton
reviewed
May 18, 2021
src/indexer/log_merge_policy.rs
Outdated
| if let Some(&(first_segment, log_size)) = sorted_segments_with_log_size.first() { | ||
| let mut current_max_log_size = log_size; | ||
| let mut levels = vec![vec![first_segment]]; | ||
| for &(segment, segment_log_size) in (&sorted_segments_with_log_size).iter().skip(1) { |
There was a problem hiding this comment.
isn't it the same without the parenthesis and the &?
There was a problem hiding this comment.
for &(segment, segment_log_size) in sorted_segments_with_log_size.iter().skip(1) {
There was a problem hiding this comment.
yes, I assume someone started with an iter on the ref &sorted_segments_with_log_size and added the skip later
PSeitz
commented
May 18, 2021
src/indexer/log_merge_policy.rs
Outdated
| .map(|ind_vec| { | ||
| MergeCandidate(ind_vec.iter().map(|&ind| segments[ind].id()).collect()) | ||
| }) | ||
| .map(|segments| MergeCandidate(segments.iter().map(|&seg| seg.id()).collect())) | ||
| .collect() | ||
| } else { | ||
| return vec![]; |
There was a problem hiding this comment.
this is dead code btw because of the early exit above
fixes a bug in log merge policy where an index was wrongly referenced by its index
fulmicoton
reviewed
May 19, 2021
| use std::cmp; | ||
| use std::f64; | ||
|
|
||
| const DEFAULT_LEVEL_LOG_SIZE: f64 = 0.75; | ||
| const DEFAULT_MIN_LAYER_SIZE: u32 = 10_000; | ||
| const DEFAULT_MIN_MERGE_SIZE: usize = 8; | ||
| const DEFAULT_MAX_MERGE_SIZE: usize = 10_000_000; | ||
| const DEFAULT_MIN_NUM_SEGMENTS_IN_MERGE: usize = 8; |
This was referenced Feb 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug in log merge policy where an index was wrongly referenced by its index